Skip to content

Mixed changes with new APIs #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2019
Merged

Mixed changes with new APIs #83

merged 1 commit into from
Apr 18, 2019

Conversation

@ekta-slit
Copy link
Collaborator

@ekta-slit ekta-slit commented Apr 18, 2019

  • Format type of YYYY-MM-DD date is updated for request schema
  • Minor fix for get sms campaign details api
  • Boolean type is added in getAttributes api call
  • New definitions getChildDomains, addChildDomain, updateChildDomain & getSsoToken added & their respective routes

aakanksha-sib
aakanksha-sib approved these changes Apr 18, 2019
View reviewed changes
Copy link

@aakanksha-sib aakanksha-sib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekta-slit ekta-slit merged commit fa4d0f4 into master Apr 18, 2019
@ekta-slit ekta-slit deleted the feature_spec-modify branch April 18, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aakanksha-sib aakanksha-sib aakanksha-sib approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ekta-slit @aakanksha-sib